Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gunmods falling out of hub 01 HWP #61160

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix gunmods falling out of hub 01 HWP #61160

merged 1 commit into from
Sep 21, 2022

Conversation

catdach
Copy link
Contributor

@catdach catdach commented Sep 20, 2022

Summary

Bugfixes "Fix integrated gunmods falling out of hub 01 HWP"

Purpose of change

Fixes #61111

The gun didn't have the proper mod locations for it's integrated mods, which made them pop out if the gun's current mods ever needed to be updated.

Describe the solution

Added the missing mod locations for the integrated gunmods. (1 rail and 1 under barrel)

Describe alternatives you've considered

none

Testing

  1. Get or spawn gun "Hub 01 HWP+5" (also, get tools to remove mods, if needed)
  2. Activate gun, select "detach gunmods" option
  3. Select regular mod to remove: "holographic sight"
    only the "holographic sight" is removed.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 20, 2022
@dseguin dseguin merged commit d14cd21 into CleverRaven:master Sep 21, 2022
@catdach catdach deleted the robofac_gunmods_fix branch September 21, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing holographic sight from HWP gun also removes integrated gun mods
2 participants
@catdach @dseguin